From 4b42fcccd6f77f69282aa4c82bcd6d0b9081fba9 Mon Sep 17 00:00:00 2001 From: Bassam <61985779+bassamanator@users.noreply.github.com> Date: Tue, 21 Nov 2023 01:24:26 -0500 Subject: [PATCH 1/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 30a0878..fe035e1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,8 +1,14 @@ # Contribution Guidelines -When contributing, please ... +When contributing, please: - provide a clear and concise explanation of your pull request. -- try to make small changes, ie, make many small pull requests as opposed to a single large pull request. This allows me to check your work more quickly, thus merge more quickly. +- try to make small changes, ie, make many small pull requests as opposed to a single large pull request. - try to follow the patterns I've already established. +Contributions to `README.md` should do some or all of the following: +- add clarity +- reduce complexity for the user +- reduce verbosity +- fix errors + Thank you. From 89183cad941ab0f64201ce7014326a104f6d3623 Mon Sep 17 00:00:00 2001 From: Bassam Husain Date: Wed, 22 Nov 2023 19:05:26 -0500 Subject: [PATCH 2/2] Adjust MECHANICAL_GANTRY_CALIBRATION.cfg: change to CONDITIONAL_BEEP. --- README.md | 2 +- cfgs/MECHANICAL_GANTRY_CALIBRATION.cfg | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 1dbf3cb..9690417 100644 --- a/README.md +++ b/README.md @@ -256,7 +256,7 @@ The printer will beep upon: - Filament runout. - Filament change/`M600`. - Upon `PRINT_END`. -- `MECHANICAL_GANTRY_CALIBRATION`/`G34` (beeping will occur even if beeping is disabled, as long as you have a speaker on your board). +- `MECHANICAL_GANTRY_CALIBRATION`/`G34`. Adjust behaviour according to your needs. diff --git a/cfgs/MECHANICAL_GANTRY_CALIBRATION.cfg b/cfgs/MECHANICAL_GANTRY_CALIBRATION.cfg index f99852c..3a9f928 100644 --- a/cfgs/MECHANICAL_GANTRY_CALIBRATION.cfg +++ b/cfgs/MECHANICAL_GANTRY_CALIBRATION.cfg @@ -72,16 +72,16 @@ gcode: SET_TMC_CURRENT STEPPER=stepper_z1 CURRENT={my_current} ; drop current {% endif %} - BEEP I=1 + CONDITIONAL_BEEP I=1 G4 P200 ; Probably not necessary, it is here just for sure SET_KINEMATIC_POSITION Z={z_max - 25} ; Trick printer into beleiving the gantry is 25mm lower than it is ; CHANGED G1 Z{z_max} F{6 * 60} ; based on above figures, there will be 20mm worth of grinding ; CHANGED - BEEP I=2 + CONDITIONAL_BEEP I=2 G4 P10000 ; wait 10 seconds G1 Z{z_max -6} F{6 * 60} ; move 4mm down - BEEP I=3 + CONDITIONAL_BEEP I=3 G4 P200 ; same as the first one SET_TMC_CURRENT STEPPER=stepper_z CURRENT={oldcurrent} HOLDCURRENT={oldhold}